ARROW-6209: [Java] Extract set null method to the base class for fixed width vectors#5064
Closed
liyafan82 wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-6209: [Java] Extract set null method to the base class for fixed width vectors#5064liyafan82 wants to merge 1 commit intoapache:masterfrom
liyafan82 wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5064 +/- ##
=========================================
+ Coverage 88.02% 89.7% +1.67%
=========================================
Files 919 670 -249
Lines 135068 99383 -35685
Branches 1418 0 -1418
=========================================
- Hits 118895 89147 -29748
+ Misses 16163 10236 -5927
+ Partials 10 0 -10Continue to review full report at Codecov.
|
Member
|
merged to master, thanks @liyafan82 ! |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…d width vectors Currently, each fixed width vector has the setNull method. All these implementations are identical, so we move them to the base class. Closes apache#5064 from liyafan82/fly_0812_null and squashes the following commits: d654a3d <liyafan82> Extract set null method to the base class for fixed width vectors Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Bryan Cutler <cutlerb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, each fixed width vector has the setNull method. All these implementations are identical, so we move them to the base class.